fix(contextchat): use a consistent item id for indexed messages - #13443
fix(contextchat): use a consistent item id for indexed messages#13443kesselb wants to merge 1 commit into
Conversation
|
/backport to stable5.10 |
Content was indexed as "{mailboxId}:{messageId}" but deleted by bare
IMAP uid, so deleting a message never removed it from the knowledge
base. Key both sides off account, mailbox and uid via a shared helper.
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
# Conflicts:
# lib/ContextChat/ContextChatProvider.php
d190fbe to
7fadd20
Compare
|
/backport to stable5.11 |
edward-ly
left a comment
edward-ly
left a comment
There was a problem hiding this comment.
Also roping in @marcelklehr for additional insight. I'll test this later if I have time, but it looks good to me so far. Do we need to do some sort of migration as well (e.g. updating the IDs of existing items, or deleting and re-importing all messages again)?
@kyteinsky and I did some brainstorming about it (in helpdesk). It would be indeed good to reset the index. The best option for now seems to change the provider id. My first idea was to trigger deleteProvider with a migration, but Anupam explain it runs async and hence we cannot really know when it's done. By using a different provider id deleting and re-importing can run in parallel. |
Follow up |
3 participants
Content was indexed as "{mailboxId}:{messageId}" but deleted by bare IMAP uid, so deleting a message never removed it from the knowledge base. Key both sides off account, mailbox and uid via a shared helper.
馃 AI (if applicable)